Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

/results page doesn't work #351

Open
jfly opened this issue Feb 21, 2017 · 1 comment
Open

/results page doesn't work #351

jfly opened this issue Feb 21, 2017 · 1 comment
Milestone

Comments

@jfly
Copy link
Member

jfly commented Feb 21, 2017

It looks like this code didn't get ported over to the new react/flow-router infrastructure.

I see a lot of calls to subscribe:

~/gitting/ccm @kaladin> git grep "subscribe.*roundResults"
both/routes.js:      return [subs.subscribe('roundResults',
imports/startup/client/router.jsx:    this.register(Meteor.subscribe('roundResults', params.competitionUrlId, params.eventCode, parseInt(params.nthRound)));
imports/startup/client/router.jsx:    this.register('roundResults', Meteor.subscribe('roundResults', params.competitionUrlId, params.eventCode, parseInt(params.nthRound)));
imports/startup/client/router.jsx:      //<<<this.register('roundResults', Meteor.subscribe('roundResults', params.competitionUrlId, params.eventCode, parseInt(params.nthRound)));
imports/ui/components/resultsList.jsx:  Meteor.subscribe('roundResults', props.competitionUrlId, props.eventCode, parseInt(props.nthRound));
imports/ui/pages/competition/competitionResults.jsx:  Meteor.subscribe('roundResults', props.competitionUrlId, props.eventCode, parseInt(props.nthRound));

I'm guessing that both/routes.js is going to eventually be deleted? Can it be deleted already?

It looks like some subscription code is happening in the top level router, and other is happening in container components. We should only be doing 1 of those 2 things, right?

@coder13
Copy link
Member

coder13 commented Feb 21, 2017

What exactly didn't get ported?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants