Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of publishing #829

Open
chipshort opened this issue Oct 8, 2024 · 1 comment
Open

Wrong order of publishing #829

chipshort opened this issue Oct 8, 2024 · 1 comment
Labels
bug Not as expected

Comments

@chipshort
Copy link

We set up cargo-release for the https://github.com/CosmWasm/cosmwasm workspace, but it seems the order of publishing for crates is not detected correctly. It tries to publish the dependent before the dependency, resulting in a failure mid-publishing.

To reproduce:
From the release/2.2 branch in cosmwasm, run cargo release 2.2.0-rc.3 -x. It tries to publish cosmwasm-std before cosmwasm-schema even though the former has a dev-dependency on the latter. This causes cargo to fail publishing. Here are the relevant outputs for when I encountered this with rc.2:

Release
  cosmwasm-core 2.2.0-rc.2
  cosmwasm-crypto 2.2.0-rc.2
  cosmwasm-derive 2.2.0-rc.2
  cosmwasm-std 2.2.0-rc.2
  cosmwasm-vm-derive 2.2.0-rc.2
  cosmwasm-vm 2.2.0-rc.2
  cosmwasm-check 2.2.0-rc.2
  cosmwasm-schema-derive 2.2.0-rc.2
  cosmwasm-schema 2.2.0-rc.2
  Compiling cosmwasm-derive v2.2.0-rc.2 (/Users/christoph/Projects/cosmwasm/target/package/cosmwasm-derive-2.2.0-rc.2)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.78s
    Packaged 5 files, 14.5KiB (3.5KiB compressed)
   Uploading cosmwasm-derive v2.2.0-rc.2 (/Users/christoph/Projects/cosmwasm/packages/derive)
    Uploaded cosmwasm-derive v2.2.0-rc.2 to registry `crates-io`
note: waiting for `cosmwasm-derive v2.2.0-rc.2` to be available at registry `crates-io`.
You may press ctrl-c to skip waiting; the crate should be available shortly.
   Published cosmwasm-derive v2.2.0-rc.2 at registry `crates-io`
  Publishing cosmwasm-std
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /Users/christoph/Projects/cosmwasm/packages/vm/Cargo.toml
workspace: /Users/christoph/Projects/cosmwasm/Cargo.toml
    Updating crates.io index
   Packaging cosmwasm-std v2.2.0-rc.2 (/Users/christoph/Projects/cosmwasm/packages/std)
   Verifying cosmwasm-std v2.2.0-rc.2 (/Users/christoph/Projects/cosmwasm/packages/std)
    Updating crates.io index
error: failed to verify package tarball

Caused by:
  failed to select a version for the requirement `cosmwasm-schema = "^2.2.0-rc.2"`
  candidate versions found which didn't match: 2.2.0-rc.1, 2.1.4, 2.1.3, ...
  location searched: crates.io index
  required by package `cosmwasm-std v2.2.0-rc.2 (/Users/christoph/Projects/cosmwasm/target/package/cosmwasm-std-2.2.0-rc.2)`
  if you are looking for the prerelease package it needs to be specified explicitly
      cosmwasm-schema = { version = "2.2.0-rc.1" }

Maybe the problem is that dev-dependencies are not factored into the ordering?

@epage
Copy link
Collaborator

epage commented Oct 8, 2024

We ignore dev-dependencies to break cycles

// Ignore dev dependencies. This breaks dev dependency cyles and allows for
// correct publishing order when a workspace package depends on the root package.
// It would be more correct to ignore only dev dependencies without a version
// field specified. However, cargo_metadata exposes only the resolved version of
// a package, and not what semver range (if any) is requested in Cargo.toml.
let non_dev_pkgs = n.deps.iter().filter_map(|dep| {
let dev_only = dep
.dep_kinds
.iter()
.all(|info| info.kind == cargo_metadata::DependencyKind::Development);
if dev_only {
None
} else {
Some(&dep.pkg)
}

However, we should only do that if the package is missing a version

@epage epage added the bug Not as expected label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not as expected
Projects
None yet
Development

No branches or pull requests

2 participants