Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update consumer genesis transform #2373

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: update consumer genesis transform #2373

wants to merge 2 commits into from

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Oct 25, 2024 •
edited
Loading

Description

Closes: #2359

To support consumer genesis transformation for ICS consumer versions pre v6.2.x
v5.x target was added to genesis transform command.

Note: This PR removes older target versions v2.x, v3.x of the genesis transform command that are not supported anymore.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@bermuell bermuell self-assigned this Oct 25, 2024
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler labels Oct 25, 2024
@bermuell bermuell force-pushed the bernd/2359-broken-consumer branch 2 times, most recently from 9652a1d to f950c3f Compare October 25, 2024 08:57
@bermuell bermuell marked this pull request as ready for review October 25, 2024 09:12
@bermuell bermuell requested a review from a team as a code owner October 25, 2024 09:12
@bermuell bermuell requested a review from mpoke October 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@bermuell bermuell

Labels
C:CI Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Integration of consumer versions v5.x with provider version v6.2.x is broken
2 participants
@bermuell @mpoke