Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate tokens before stopping a consumer chain #2094

Open
insumity opened this issue Jul 25, 2024 · 2 comments
Open

Allocate tokens before stopping a consumer chain #2094

insumity opened this issue Jul 25, 2024 · 2 comments
Assignees
Labels
type: bug Issues that need priority attention -- something isn't working

Comments

@insumity
Copy link
Contributor

Problem

Currently if a consumer chain is stopped/removed, the rewards sent to this consumer chain might not be given to the consumer validators. This is because the reward distribution takes place after the consumer chain has been removed. This issue is about investigating whether we should distribute the rewards before the chain stops.

@ukane-philemon
Copy link

Problem

Currently if a consumer chain is stopped/removed, the rewards sent to this consumer chain might not be given to the consumer validators. This is because the reward distribution takes place after the consumer chain has been removed. This issue is about investigating whether we should distribute the rewards before the chain stops.

Is it possible to have an intermediary state to allow for the distribution of rewards before connections are dropped due to stopping the chains?

am.keeper.BeginBlockMCR(sdkCtx) // Mark Chain for removal.
am.keeper.BeginBlockRD(sdkCtx) // Reward distribution
am.keeper.BeginBlockCCR(sdkCtx) // Consumer Chains Removal

@mpoke
Copy link
Contributor

mpoke commented Sep 17, 2024

@insumity this is fixed by ICS 6.0.0, right? The new behavior is to first stop a chain and then after the unbonding period elapses remove its state. Could you please confirm that's the case?

@mpoke mpoke added type: feature-request New feature or request improvement type: bug Issues that need priority attention -- something isn't working and removed type: feature-request New feature or request improvement good first issue Good for newcomers labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues that need priority attention -- something isn't working
Projects
Status: 🤔 F1: Investigate
Development

No branches or pull requests

3 participants