Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up windows #24

Open
pmcdonal opened this issue Aug 22, 2023 · 4 comments
Open

clean up windows #24

pmcdonal opened this issue Aug 22, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@pmcdonal
Copy link
Member

Attached is what the first k_obs element of this ELG quadrupole window matrix:
/global/cfs/cdirs//desi/survey/catalogs/Y1/LSS/iron/LSScats/v0.4/blinded/pk/pk/wmatrix_smooth_ELG_LOPnotqso_NGC_0.8_1.1_default_FKP_lin.npy
looks like (when rebin=5)

ELGquadW.pdf

Monopole is not as bad and it improves quickly with increasing k_obs. Ok, a short-term solution is to just drop low k elements, but we at least need to figure out what is good enough to include when publishing...

@pmcdonal pmcdonal added the bug Something isn't working label Aug 22, 2023
@adematti
Copy link
Member

Thanks for the report, looks pretty bad indeed! I'll see whether there is anything obvious to do about this in the quite ad-hoc process of building this window matrix.

@adematti
Copy link
Member

I haven't figured out yet an easy way to damp these wiggles, except of course applying a Gaussian damping beyond e.g. k > 0.1 h/Mpc to the k-window (i.e. the power of the randoms that's fed into the window matrix computation)...

@pmcdonal
Copy link
Member Author

Do you understand why they are there? They aren't so bad for all cases - it isn't clear in my head if it is possible that something with some oscillation is actually correct, with this just being more ratty than it should be for numerical reasons... (the z slice is not really very wide, with sharp edges... these slices being another thing I wish we'd had time to think about more carefully...)

@adematti
Copy link
Member

adematti commented Aug 31, 2023

I'll try to compute the window matrix for increasingly complex geometries to get some intuition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants