Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No functionality of qbao parameter in DirectWiggleSplitPowerSpectrumTemplate #37

Open
erikzaborowski opened this issue Aug 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@erikzaborowski
Copy link
Contributor

erikzaborowski commented Aug 9, 2024

Hi, sometime between now and May 7 (when I was able to successfully train some emulators with qbao), I think the qbao parameter has become broken in DirectWiggleSplitPowerSpectrumTemplate. Here is some code that shows that the theory doesn't vary with qbao, but does vary e.g. with Omega_m:

import numpy as np
from desilike.theories.galaxy_clustering import LPTVelocileptorsTracerPowerSpectrumMultipoles
from desilike.theories.galaxy_clustering import DirectWiggleSplitPowerSpectrumTemplate
template_marg_test = DirectWiggleSplitPowerSpectrumTemplate(z=1.0)
theory_marg_noem_test = LPTVelocileptorsTracerPowerSpectrumMultipoles(template=template_marg_test, prior_basis='physical', tracer='LRG')
np.any(theory_marg_noem_test(qbao=1.0) - theory_marg_noem_test(qbao=1.15) != 0)
np.any(theory_marg_noem_test(Omega_m=0.3) - theory_marg_noem_test(Omega_m=0.35) != 0)

Thank you for any help!

@erikzaborowski erikzaborowski added the bug Something isn't working label Aug 9, 2024
@erikzaborowski
Copy link
Contributor Author

For what it's worth, the latest commit on DirectWiggleSplitPowerSpectrumTemplate was 97e3b19, and if I checkout the last commit before that one, things work again.

@adematti
Copy link
Member

Thanks Erik! --- sorry about this! the last commit should fix it again

@erikzaborowski
Copy link
Contributor Author

Thanks Arnaud! I'm guessing maybe related to this change, but if I source the cosmodesi env and try import desilike I get a ModuleNotFoundError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants