-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump files are skipped using absolute path file #902
Open
vallsv opened this issue
May 7, 2022
· 2 comments
· Fixed by absolute-version/commit-and-tag-version#1 · May be fixed by #903
Open
Bump files are skipped using absolute path file #902
vallsv opened this issue
May 7, 2022
· 2 comments
· Fixed by absolute-version/commit-and-tag-version#1 · May be fixed by #903
Labels
Comments
vallsv
changed the title
Bump file are skipped using absolute path file
Bump files are skipped using absolute path file
May 7, 2022
I also don't really understand why files are filtered based on |
Just stumbled onto the same bug, thanks for reporting @vallsv (same behaviour on 9.5.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
standard-version
was never bumpingpackage.json
on one of my project.After some checks it looks like the file is filtered based on the absolute path of the file.
As result
dotgitignore
can incorrectly answer that a file is ignored by.gitignore
based on parent directory not part of the project.How to reproduce
/home/user/myproject/
withpackage.json
.gitignore
containinghome
package.json
is not updated because the abs path/home/user/myproject/package.json
containshome
Current behavior
My
package.json
is not bumped.Expected behavior
My
package.json
have to be bumped.Environment
standard-version@9.3.2
dotgitignore@2.1.0
Possible Solution
Use relative path instead of absolute path for
configFiles
The text was updated successfully, but these errors were encountered: