-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug - Text component should not take "color" prop #2339
Comments
Marking issue as stale since there was no activity for 30 days |
github-actions
bot
added
the
stale
Used to mark when there was no activity for a set period of time
label
Dec 25, 2022
@denkristoffer, could you provide an example of how you're passing in |
github-actions
bot
removed
the
stale
Used to mark when there was no activity for a set period of time
label
Jan 3, 2023
Thanks for requesting that @Wake1st, I've added an example to the issue. |
Marking issue as stale since there was no activity for 30 days |
github-actions
bot
added
the
stale
Used to mark when there was no activity for a set period of time
label
Feb 3, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Forma 36 bug report
Summary
The
Text
component should not take the propcolor
but instead throw a type error. I keep usingcolor
instead offontColor
because I'm silly and I never get an error, but I don't get the result I expect either 🙁 The prop type comes from the fact that we're extending the default HTML attributes. We should probablyOmit
color
.Example: https://f36.contentful.com/playground?code=N4Igxg9gJgpiBcICWBbADhATgFwATFwDEAbGADwBpcAVcvAX1wDNMIVcByAAUgDtsY-JgFdiAeiYBmAGwBaSOgi9B2AM4cA3AB1eO8hhy5YTAIai8I3mGxIluAIJo0ACgCU+HblyYY2YZl5cAB4ScmZSMgARJB9rW14AXi1wCGJhFF0QAD5PL2DaMjxIYiwkkB8oAFYABmrkrIBJXFUACwhRKFxsFtYAd1wTLoBPNBhcGExWTABCILEC7BzAvKCF5iVsAGFU0uSKmrrsptb24k6AIzGK2fm6Ja850LIl+hB6IA
The text was updated successfully, but these errors were encountered: