Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skopeo inspect outright fails with OCI artifacts #1933

Open
mpagot opened this issue Mar 6, 2023 · 6 comments
Open

Skopeo inspect outright fails with OCI artifacts #1933

mpagot opened this issue Mar 6, 2023 · 6 comments
Labels
kind/feature A request for, or a PR adding, new functionality stale-issue

Comments

@mpagot
Copy link

mpagot commented Mar 6, 2023

With Skopeo 1.5.0 I was able to get

% podman run -it skopeo/stable:v1.5.0 inspect docker://registry.opensuse.org/devel/sap/trento/factory/charts/trento/trento-server:1.2.2-dev2

{
    "Name": "registry.opensuse.org/devel/sap/trento/factory/charts/trento/trento-server",
...
    "Env": null
}

With the latest Skopeo version I have an error

% podman run -it skopeo/stable:v1.11.1 inspect docker://registry.opensuse.org/devel/sap/trento/factory/charts/trento/trento-server:1.2.2-dev2

FATA[0000] unsupported image-specific operation on artifact with type "application/vnd.cncf.helm.config.v1+json"
@mtrmac
Copy link
Contributor

mtrmac commented Mar 6, 2023

Thanks for your report.

The change to refuse to provide image-specific data for non-image artifacts is intentional, although we didn’t anticipate that completely breaking skopeo inspect.

What do you actually use skopeo inspect for in this case? The only data that is relevant for the artifact is name (already known to the user), other tags in the repo (available via list-tags), and data about the blob digests/MIME types/sizes.

So what is the necessary output? Is it essentially an image presence check? Is the goal to list data about the blobs (and if so, for what purpose)? Something else?

@mpagot
Copy link
Author

mpagot commented Mar 6, 2023

Last version working for me is 1.8.0. First version with this FATA is 1.9.0
Looking at the code I'd guess it has been introduced with 62158a5

@mpagot
Copy link
Author

mpagot commented Mar 6, 2023

I agree with you that skopeo inspect is not needed for helm chart

Feel free to close this issue

@mtrmac
Copy link
Contributor

mtrmac commented Mar 6, 2023

I think this report is valuable — and I meant the question about what is the purpose and expected output.


On the one hand, the current fields of skopeo inspect are mostly inapplicable to artifacts, and there are no reasonable substitute values that could be used instead (e.g. for architecture), so just failing does seem appropriate right now.

OTOH, there are probably some uses of skopeo inspect that make sense; at the very least “what is that thing at all?” is a question that should be possible to answer using skopeo inspect in some reasonably convenient way.

Compare #1283 . At this point it’s not clear to me what a good UI would look like, so I’m starting by looking for use cases.

@mtrmac mtrmac changed the title Skopeo inspect with helm charts Skopeo inspect outright fails with OCI artifacts Mar 6, 2023
@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Mar 6, 2023
@mpagot
Copy link
Author

mpagot commented Mar 7, 2023

My use case use a script calling skopeo inspect in a loop against a mixed list of images and artifact. The output was only used to create a log file for possible further debug. So I'm not expecting any particular content. For my particular use case I'll probably improve the loop by checking the type of image and skip the skopeo inspect for the artifacts.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

A friendly reminder that this issue had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for, or a PR adding, new functionality stale-issue
Projects
None yet
Development

No branches or pull requests

2 participants