Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make recipe friendlier to those that build off it #578

Open
hmaarrfk opened this issue Aug 31, 2022 · 1 comment
Open

Make recipe friendlier to those that build off it #578

hmaarrfk opened this issue Aug 31, 2022 · 1 comment
Labels

Comments

@hmaarrfk
Copy link

Comment:

I maintain python for my company and we try to stay close to the conda-forge recipe. We aim to be compatible with conda-forge rather than defaults.

However, things like

      string: {{ dev_ }}h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}{{ linkage_nature }}{{ debug }}_cpython  # ["conda-forge" in (channel_targets or "")]
      string: h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}{{ linkage_nature }}{{ debug }}  # ["conda-forge" not in (channel_targets or "")]
{% if 'conda-forge' in channel_targets %}
      run_exports:
        noarch:
          - python
        weak:
          - python_abi {{ ver2 }}.* *_cp{{ ver2nd }}
{% endif %}

Link: main as of 2022/08/31

string: {{ dev_ }}h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}{{ linkage_nature }}{{ debug }}_cpython # ["conda-forge" in (channel_targets or "")]

My guess is that this syntax was introduced to be compatible with AnacondaRecipes.

Package for me often fail to install with our built version of python, because they are looking for something with a build ending in _cpython.

I'm wondering if we can work to find a syntax that is more generalizable to other people building off the conda-forge recipe as well.

@jakirkham
Copy link
Member

What would you propose instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants