[1.0 XMR] Provide better feedback when cancel/refund transaction publish fails by parsing electrum error

[thomaseizinger]

As discovered in #674, users may try to refund a swap even though that is no longer possible because Alice already punished.

We should catch this case by parsing the error message returned from electrum and display something more informative to the user.

Also, we need to advance the internal state to correctly reflect what happened on the blockchain, otherwise swap list returns misleading information.

[da-kami]

Duplicate of #455

[binarybaron]

We use bounties to incentivize development and reward contributors. All issues available for a bounty have the Bounty 💰 label.

To receive the bounty of this issue, you agree to these conditions:

• Your changes must follow the styling guidelines.
• Bounties will be set and awarded at discretion of @binarybaron .
  The issues eligible for a bounty are labelled 'Bounty 💰' and have the amount of the bounty specified in the title in this form: [1 XMR].
• An issue is considered resolved when the patch(es) proposed by the contributor is/are merged in the appropriate repository according to terms of the issue.
• The first person who resolves an issue in its entirety will receive the entire amount of the bounty.
• If the issue is resolved collaboratively by more than one person, the reward will be distributed among the contributors
• Let the Maintainers know if you intend to work on a bounty, so that the issue can be assigned to you. Being assigned to an issue doesn't make that issue resolvable only by the assignee. It's meant to avoid duplication of efforts and not to discourage collective works.
• After the issue is resolved, contact @binarybaron and claim your bounty (remember to provide them with a Monero address).

[binarybaron]

@delta1 Would you be interested in taking this on?

[delta1]

Yes definitely! Will pick it up after getting #1081 fixed and released for the hard fork

[binarybaron]

I did start working on this a bit. I'll publish my WIP branch later, if @delta1 or anyone else wants to pick up from where I left

[delta1]

Yeah was taking a look! Happy to pick it up - please share your branch name

[binarybaron]

master...binarybaron:xmr-btc-swap:detect-timelocks-manual-refund

[binarybaron]

Increased bounty to 0.5 XMR! @delta1 @lescuer97

[delta1]

Nice! Picking this back up tomorrow 👌

[binarybaron]

Any updates? Have you had time to take a look at this again?

[delta1]

No updates, sorry have been dealing with personal issues so if somebody else could pick it up that’s totally fine. Otherwise I can get back to it in a couple of weeks.

[binarybaron]

I'm increasing the bounty to 1 XMR because I believe this will provide some major benefits in terms of usability! @lescuer97 @delta1 @ALL

[thenhnn]

@binarybaron I'm increasing the bounty to 1 XMR because I believe this will provide some major benefits in terms of usability!

I'm interested, can I try to implement this?

[delta1]

sure @thenhnn go ahead

[thenhnn]

@delta1 sure @thenhnn go ahead

Please check #1571

[patrini32]

Can you check #1688, please?