TypeScript type definition file

[kseo]

Adding a TypeScript type definition file for transit-js will be helpful for TypeScript developers.

[phreed]

I know...
" Because transit is incorporated into products and client projects, we prefer to do development internally and are not accepting pull requests or patches."
...but here is hoping.

[swannodette]

@phreed @kseo I finally found time to update the project so it can build again at least locally. It would be nice to get some outside confirmation before we proceed. Thanks.

[phreed]

I get the following warnings and errors... [with a clean clone]. $ bin/build_release_node src/com/cognitect/transit/types.js:256: WARNING - Redeclared variable: eidx eidx = eidx || (sidx+1); ^^^^^^^^^^^^^^^^^^^^^^^^ src/com/cognitect/transit/types.js:318: WARNING - Redeclared variable: s var s = s.replace(/-/g, ""), ^^^^^^^^^^^^^^^^^^^^^^^^^^ deps/closure-library/closure/goog/html/sanitizer/csssanitizer_test.js:34: ERROR - Variable isIE8 first declared in deps/closure-library/closure/goog/html/sanitizer/unsafe_test.js function isIE8() { ^^^^^ deps/closure-library/closure/goog/html/sanitizer/htmlsanitizer_test.js:41: ERROR - Variable isIE8 first declared in deps/closure-library/closure/goog/html/sanitizer/unsafe_test.js function isIE8() { ^^^^^ deps/closure-library/closure/goog/html/sanitizer/htmlsanitizer_test.js:49: ERROR - Variable isIE9 first declared in deps/closure-library/closure/goog/html/sanitizer/unsafe_test.js function isIE9() { ^^^^^ deps/closure-library/closure/goog/html/sanitizer/htmlsanitizer_test.js:61: ERROR - Variable assertSanitizedHtml first declared in deps/closure-library/closure/goog/html/sanitizer/unsafe_test.js function assertSanitizedHtml(originalHtml, expectedHtml, opt_sanitizer) { ^^^^^^^^^^^^^^^^^^^ deps/closure-library/closure/goog/html/sanitizer/htmlsanitizer_test.js:1312: ERROR - Variable just first declared in deps/closure-library/closure/goog/html/sanitizer/unsafe_test.js var just = goog.string.Const.from('test'); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 5 error(s), 2 warning(s)

…

On Fri, May 12, 2017 at 4:03 PM David Nolen ***@***.***> wrote: @phreed <https://github.com/phreed> @kseo <https://github.com/kseo> I finally found time to update the project so it can build again at least locally. It would be nice to get some outside confirmation before we proceed. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM6vF1_TJNRFFdrFEa7Z5Lkm6s-mp9xks5r5MkugaJpZM4MPX3U> .

[swannodette]

@phreed try now, I've updated all the build scripts to reflect the latest Closure CLI.

[phreed]

great, it seems to build correctly, now to try it out.

…

On Fri, May 19, 2017 at 2:59 PM David Nolen ***@***.***> wrote: @phreed <https://github.com/phreed> try now, I've updated all the build scripts to reflect the latest Closure CLI. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM6vGZe1x-LYCiL3jbhAo34BKs-EtB_ks5r7fSugaJpZM4MPX3U> .

[phreed]

The typings seem to be working but I am getting a bug in the execution.
In ./node_modules/transit-js/src/com/cognitect/transit/handlers.js : 338

 if (typeof goog.global.Buffer != "undefined") {
     hs.set(goog.global.Buffer, new handlers.BufferHandler());
 }

...which in the Closure compiler converts into ./target/transit.js as...

 "undefined" != typeof h.G && this.set(h.G, new lb);

In that context h is undefined and an exception is thrown.
A couple questions:

• What is goog.global and why is it undefined?
• How should I be debugging this?

I should mention this is in a Node.js context.

[swannodette]

@phreed Google Closure doesn't know about Node.js buffer, let me think about this some more.

[phreed]

As an aside...
Are there clojure.spec definitions for the transit api?
[I made a cursory check but did not see any.]
I am curious if the specs are sufficiently rich to be able to generate typings.
And if they are not what would be needed to make them so?
The question is inspired by this guy...
https://youtu.be/Rlu-X5AqWXw?t=3m

[swannodette]

No spec. Forgot to check the issue and realize I need to look into this Buffer issue, will do so tomorrow.

[swannodette]

@phreed can you please describe steps to reproduce that issue? I cannot reproduce it. goog.global is provided by goog/base.js it should be defined.

[phreed]

I won't be in a position to check it out until Tuesday.

…

On Fri, Sep 1, 2017 at 2:36 PM David Nolen ***@***.***> wrote: @phreed <https://github.com/phreed> can you please describe steps to reproduce that issue? I cannot reproduce it. goog.global is provided by goog/base.js it should be defined. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM6vI8kAQCOhRWwtvaVbVYlx0HfNfAiks5seE6ogaJpZM4MPX3U> .

[phreed]

I am made a pull request #43