Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code to 1.95 #7052

Open
benz0li opened this issue Oct 26, 2024 · 9 comments · May be fixed by #7059
Open

Update Code to 1.95 #7052

benz0li opened this issue Oct 26, 2024 · 9 comments · May be fixed by #7059
Labels
enhancement Some improvement that isn't a feature

Comments

@benz0li
Copy link
Contributor

benz0li commented Oct 26, 2024

What is your suggestion?

Update Code to 1.95

Why do you want this feature?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

@benz0li benz0li added the enhancement Some improvement that isn't a feature label Oct 26, 2024
@benz0li
Copy link
Contributor Author

benz0li commented Oct 26, 2024

Expected release date: 10/29 (this may change)

microsoft/vscode#231789

@benz0li
Copy link
Contributor Author

benz0li commented Oct 26, 2024

Note to self: Check Node.js version in lib/vscode/remote/.npmrc. Update .node-version and package.json accordingly.

@Kidsunbo
Copy link

Still wait for v4.94.2 to be released..

@benz0li
Copy link
Contributor Author

benz0li commented Oct 29, 2024

Code - OSS v1.95.0 was released today: https://github.com/microsoft/vscode/releases/tag/1.95.0

@benz0li
Copy link
Contributor Author

benz0li commented Oct 29, 2024

@code-asher I will try to create a pull request early next morning (CET).

@benz0li
Copy link
Contributor Author

benz0li commented Oct 30, 2024

@code-asher You mixed pre and post build patches:

quilt push -f
...
can't find file to patch at input line 279
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: code-server/lib/vscode/src/server-main.js
|===================================================================
|--- code-server.orig/lib/vscode/src/server-main.js
|+++ code-server/lib/vscode/src/server-main.js
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
Applied patch patches/integration.diff (forced; needs refresh)

ℹ This means that I am unable to do the preparatory work for this release.

@code-asher
Copy link
Member

code-asher commented Oct 30, 2024

Hmm I am not sure that is quite right, they used to write and commit server-main.js directly so it was never post-build before, just a regular source file like anything else. It looks like they renamed server-main.js to server-main.ts (and added types), so we will have to update to patch the renamed file now.

@benz0li
Copy link
Contributor Author

benz0li commented Oct 31, 2024

This was a hasty conclusion of mine, then.

@code-asher Can you tackle this?

@code-asher
Copy link
Member

Yup, no problem!

@code-asher code-asher linked a pull request Oct 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants