Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code server startup script is failing with error 'error Unexpected ( at 18, expected END: https://git.new/pathToRegexpError' #7002

Open
1 of 2 tasks
mkc450 opened this issue Sep 15, 2024 · 1 comment
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer

Comments

@mkc450
Copy link

mkc450 commented Sep 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

Web Browser: Chrome
Local OS: macOS
Remote OS: Ubuntu
Remote Architecture: amd64
code-server --version: 4.90.3

Steps to Reproduce

Start up command failed with the following error.

error Unexpected ( at 18, expected END: https://git.new/pathToRegexpError

We run npm audit fix --force before start up command to fix all vulnerable node packages.

Which upgraded version for path-to-regexp from 3.2.0 to 8.0.1 and its a breaking change for code-server with above mentioned error.

Below are the references which got upgraded.
GHSA-9wv6-86v2-598j
GHSA-qw6h-vgh9-j6wx

For now I downgraded the express to 4.21.0 and its dependency path-to-regexp@0.1.10 is used.

Expected

code server should be started, post upgrading vulnerable packages.

Actual

code server is not started

Logs

error Unexpected ( at 18, expected END: https://git.new/pathToRegexpError

Screenshot/Video

No response

Does this bug reproduce in native VS Code?

I did not test native VS Code

Does this bug reproduce in GitHub Codespaces?

I did not test GitHub Codespaces

Are you accessing code-server over a secure context?

  • I am using a secure context.

Notes

No response

@mkc450 mkc450 added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Sep 15, 2024
@code-asher
Copy link
Member

I am not sure this is something we can fix? If I understand correctly, this is a dependency of Express so we have to wait until Express is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants