Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Node 18 #6230

Closed
henkery opened this issue May 23, 2023 · 9 comments · Fixed by #6436
Closed

Migrate to Node 18 #6230

henkery opened this issue May 23, 2023 · 9 comments · Fixed by #6436
Labels
enhancement Some improvement that isn't a feature

Comments

@henkery
Copy link
Contributor

henkery commented May 23, 2023

What is your suggestion?

Migrate code-server to use nodejs 18 instead of 16

Why do you want this feature?

nodejs 16 reaches EOL on september 2023 https://nodejs.org/en/blog/announcements/nodejs16-eol

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

I might look into making this work in a few months from now

@henkery henkery added the enhancement Some improvement that isn't a feature label May 23, 2023
@code-asher
Copy link
Member

We can do this once VS Code updates to Node 18.

@code-asher code-asher added the blocked This issue cannot proceed due to external factors label May 30, 2023
@henkery
Copy link
Contributor Author

henkery commented Jun 1, 2023

microsoft/vscode#180466
microsoft/vscode#184021
tracking update here

@code-asher code-asher changed the title [Feat]: migrate to nodejs 18 as nodejs 16 reaches EOL very soon Migrate to Node 18 Jun 26, 2023
@skapin
Copy link

skapin commented Jul 20, 2023

do you have any information on when it would be available ? september is near.

@henkery
Copy link
Contributor Author

henkery commented Jul 20, 2023

We are waiting on vscode to migrate first
seems they moved the work to a new ticket here microsoft/vscode#188268
ofc code-server (or vscode for that matter) won't just instantly break but it will be considered a security risk

@skapin
Copy link

skapin commented Jul 20, 2023

Yes, but looks like it will not be available for several month. Internally they are afraid of moving to electron 25....

meanwhile, node 16 and openssl1.1.1 is ending in september ><

Thank you, I'm crossing my finger.

For information, i'm bumping all my jupyterlab stack to 4.0 and node 18 is asked (but looks like not mandatory) anyway, I have the same issue with openssl 1.1.1 VS 3 ><

@benz0li
Copy link
Contributor

benz0li commented Jul 20, 2023

For information, i'm bumping all my jupyterlab stack to 4.0

@skapin I stay with v3.6.x for my JupyterLab docker stacks because of jupyterlab/jupyterlab#14590.

@skapin
Copy link

skapin commented Jul 20, 2023

@benz0li yeah, but my release plan is for sept/october, and I want to do it early, at least maximize compatibility.
thank you for the link, I will keep it !!!

It's out for several months now. I will clean old extension and co. Cleaning time :p

@benz0li
Copy link
Contributor

benz0li commented Aug 7, 2023

ℹ️ Update to Electron 25 (Issue: microsoft/vscode#184021; Pull Request: microsoft/vscode#188268) is part of the Iteration Plan for August 2023 [DRAFT].

@code-asher code-asher removed the blocked This issue cannot proceed due to external factors label Sep 20, 2023
@jonathanflackUSAF
Copy link

One particularly important reason for pressing Microsoft's VSCode team on this is this specific change is required to eliminate a number of Critical and High scoring CVE's, and there is a risk in many high compliance environments that these codebases could be delisted from authorized lists if this doesn't happen quickly.

We are seeing this happen in real time with a certain Australian company who make Agile process management software. Missions in the federal government are being told to immediately isolate and cut off all access to these systems.

This is a pretty dark stain on any closed source or OSS solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants