New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add via URL fails for large extensions #66

Open

janLo opened this issue Oct 25, 2024 · 1 comment

Labels

bug documentation

Contributor

janLo commented Oct 25, 2024

Large extensions like sonarlint (300+ MB) cannot be added via URL. I think the relevant part is this: https://github.com/coder/code-marketplace/blob/main/storage/storage.go#L358

I totally understand that there needs to be a limit and I see 100MB also as a good cutoff - but I do think, this should be mentioned in the docs.

coder-labeler bot added bug documentation labels

Member

code-asher commented Oct 29, 2024

Agreed, and it sees reasonable to make a flag to change this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment