Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All extensions show as unsigned by the Extension Marketplace preventing auto installation in VSCode 1.9.4+ #65

Open
angrycub opened this issue Oct 24, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@angrycub
Copy link

Problem Statement

It seems that VS Code 1.94+ is not compatible with extensions hosted in the code-marketplace. They all have this signature warning (Screenshot 1) which prevents them from being installed in the standard way i.e. blue Install button, or automatically if you’ve enabled auto updates. You can still install via the cog wheel if you proceed passed the warning (Screenshots 2 & 3).

🖥️ Screenshots

Screenshot 1
screenshot 1

Screenshot 2
screenshot 2

Screenshot 3
screenshot 3

Potentially related issues

@coder-labeler coder-labeler bot added the bug Something isn't working label Oct 24, 2024
@janLo
Copy link
Contributor

janLo commented Oct 29, 2024

We've experienced the very same issue. The signature seems not to be contained in the actual VSXI package. Instead, the extensionquery-API provides it as a separate asset for a given version.

Our solution is to download it separately (we have a mirroring mechanism which uses the extensionquery-API to fetch the version information of the extensions and passes new version assets to code-marketplace add) and put it manually next to the extension in our Artifactory repository. The reverse proxy in front of the marketplace then mangles the manifest response via embedded Lua to inject the signature asset in the response.

This way, VS Code can download the signature and stops complaining.

@code-asher
Copy link
Member

Bringing over my notes from #67:

I think we will need to implement https://github.com/filiptronicek/node-ovsx-sign in Go. We generate what we need when an extension is added, or on demand for existing extensions for backwards compatibility.

This should also allow adding your own signatures since it will only generate if one does not already exist.

@Kira-Pilot
Copy link
Member

duplicated by https://github.com/coder/customers/issues/702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants