Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Updates results in "Invalid page size" #38

Closed
mayrholu opened this issue May 22, 2024 · 5 comments
Closed

Check for Updates results in "Invalid page size" #38

mayrholu opened this issue May 22, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mayrholu
Copy link

Hi there,

I have a problem:
If I hit "Check for Extension Updates" in VSCode I get "All extensions up to date" which is definitely false as I just uploaded some new versions.
The developer tools' network section shows the following response for the update request:

{
    "message": "Invalid page size",
    "detail": "Check that the page size is between zero and fifty",
    "requestId": "806226fe-9b68-4cb3-b8bc-7ee1f50f48fc"
}{
...

Apparently VSCode requests a page size of 74 (the total count of extensions?).

Is there a way to increase the maximum page size? Or can I fix that issue myself?

Thank you in advance!

@coder-labeler coder-labeler bot added the bug Something isn't working label May 22, 2024
@code-asher
Copy link
Member

Oh interesting. The maximum page size is currently hardcoded, but we should make it configurable, maybe with a --max-page-size flag? And we could make it so if you set 0 then you can have any page size, maybe.

Definitely happy to merge a PR if you want to add this.

@mayrholu
Copy link
Author

Unfortunately I don't know Go. I could increase the hardcoded limit but I have no idea how to add a flag.

@code-asher Any chance you could implement this fix?

@code-asher
Copy link
Member

I can add it to our backlog, but I am not sure it will get picked up soon.

@code-asher code-asher self-assigned this May 23, 2024
@code-asher code-asher added good first issue Good for newcomers enhancement New feature or request and removed bug Something isn't working labels Jul 3, 2024
@code-asher code-asher assigned bcpeinhardt and unassigned code-asher Jul 16, 2024
@bcpeinhardt
Copy link
Contributor

Hey there!

We've added a flag --max-page-size to override the limit, and updated the default limit from 50 to 200, so the next release should fix this issue for you 😄

@mayrholu
Copy link
Author

Nice! Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants