Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to pages to include complete scheme + domain name #25

Open
migurski opened this issue Sep 12, 2014 · 7 comments · Fixed by #41
Open

Fix links to pages to include complete scheme + domain name #25

migurski opened this issue Sep 12, 2014 · 7 comments · Fixed by #41
Labels

Comments

@migurski
Copy link
Contributor

Report from a user:

As it works now, when I click on a page listed in one of the columns, it opens a separate window but truncates or main url. For example, instead of going to http://www.example.org/employment, it goes to /employment. Is there a part of the setup that I missed or is this how it works?

@migurski migurski added the bug label Sep 12, 2014
@phae
Copy link
Contributor

phae commented Feb 25, 2015

I think it might be a bit missed. I think it's because the domain needs to be set in the root of the app. Will check.

@boonrs
Copy link

boonrs commented Mar 2, 2015

We deployed this for City of Boulder and are seeing the same issue. When I take a look at the environment variables, GA_WEBSITE_URL is set correctly to the domain.

@rpringle
Copy link
Contributor

rpringle commented Mar 3, 2015

I fixed this in Boulder's instance by hard-coding the domain into the index.html template. It looks like the content.js file needs to have the domain defined as a var under content.pages.push (line 18) but I'm unsure of where to parse it from. I don't know if it's part of the response from the endpoint call or not.

@phae
Copy link
Contributor

phae commented Mar 3, 2015

Hmm. It may be a value that ought to be collected during the setup-app process. @migurski?

@phae phae closed this as completed in #41 Mar 3, 2015
@rpringle
Copy link
Contributor

rpringle commented Mar 4, 2015

Hi @phae, can you re-open this issue since my fix didn't work across both of our instances? Technically it's still broken for us (I fixed in our Heroku instance but it's basically a fork at this point).

@phae
Copy link
Contributor

phae commented Mar 4, 2015

Sorry! Thought I had done!

@phae phae reopened this Mar 4, 2015
@rpringle
Copy link
Contributor

rpringle commented Mar 4, 2015

No worries, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants