Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H-03 MitigationConfirmed #25

Open
c4-bot-4 opened this issue Sep 16, 2024 · 1 comment
Open

H-03 MitigationConfirmed #25

c4-bot-4 opened this issue Sep 16, 2024 · 1 comment
Labels
mitigation-confirmed MR-H-03 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-4
Copy link
Contributor

Lines of code

Vulnerability details

C4 issue

H-03: A DoS on snapshots due to a rounding error in calculations.

Comments

In the original implementation, an integer underflow could occur when calculating slashAssets during the NativeVault._startSnapshot() function.

Mitigation

H-03

The mitigation effectively prevents integer underflow.

I confirm that the mitigation has resolved the original issue.

Conclusion

LGTM
c4-bot-5 added a commit that referenced this issue Sep 16, 2024
@c4-bot-5
KupiaSec issue #25
68d3073
@c4-judge
Copy link

MiloTruck marked the issue as satisfactory

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mitigation-confirmed MR-H-03 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c4-judge @c4-bot-4