-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA Report #41
Comments
https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/shaflow2-Q.md#02-the-decrposition09293696-function-is-missing-a-parameter We'll fix this. But is this a dupe of another submission? https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/shaflow2-Q.md#05-the-transfer_position_e_e_c7_a3_c_d-function-has-incorrect-descriptions-in-its-calling-requirements-comments We'll fix the code to be in line with the comment, as well as supporting the NFT manager. https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/shaflow2-Q.md#06-single-token-approvals-should-not-be-able-to-call-approve We'll fix this. But is this a dupe? |
Adding the |
alex-ppg marked the issue as grade-b |
See the markdown file with the details of this report here.
The text was updated successfully, but these errors were encountered: