QA Report

[c4-bot-6]

See the markdown file with the details of this report here.

[af-afk]

https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/shaflow2-Q.md#01-the-swap-function-does-not-check-whether-the-amount-is-zero Is this a dupe?

https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/shaflow2-Q.md#02-the-decrposition09293696-function-is-missing-a-parameter We'll fix this. But is this a dupe of another submission?

https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/shaflow2-Q.md#03-the-quote2cd06b86e-function-has-misleading-parameter-comments We'll fix this.

https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/shaflow2-Q.md#04-the-position_tick_upper_67_f_d_55_b_a-function-contains-misleading-variable-names We'll fix this.

https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/shaflow2-Q.md#05-the-transfer_position_e_e_c7_a3_c_d-function-has-incorrect-descriptions-in-its-calling-requirements-comments We'll fix the code to be in line with the comment, as well as supporting the NFT manager.

https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/shaflow2-Q.md#06-single-token-approvals-should-not-be-able-to-call-approve We'll fix this. But is this a dupe?

[liveactionllama]

Adding the sufficient quality label on behalf of the validator.

[c4-judge]

alex-ppg marked the issue as grade-b