Post-Judging QA #101
Replies: 30 comments 8 replies
-
left a comment at code-423n4/2024-07-karak-validation#344 |
Beta Was this translation helpful? Give feedback.
-
Hello @MiloTruck thanks for the judging, i have left a comment on code-423n4/2024-07-karak-validation#142 because it have been wrongly validated by validators, and it's a dupe of #93 . Please review it thanks. |
Beta Was this translation helpful? Give feedback.
-
Hello @MiloTruck , thanks for ur time here . i left some comments on 89 , 154, 167 and 173 Thanks. |
Beta Was this translation helpful? Give feedback.
-
hello @MiloTruck |
Beta Was this translation helpful? Give feedback.
-
hello @MiloTruck thanks for judging left some comments on |
Beta Was this translation helpful? Give feedback.
-
Hey @MiloTruck, |
Beta Was this translation helpful? Give feedback.
-
Hi @MiloTruck Thanks for judging! Left a comment on #80 |
Beta Was this translation helpful? Give feedback.
-
@MiloTruck |
Beta Was this translation helpful? Give feedback.
-
Hi @MiloTruck |
Beta Was this translation helpful? Give feedback.
-
Hello @MiloTruck, Thank you for the judging. Kindly asking you to take a look at my comment on this issue: 308. Best wishes! |
Beta Was this translation helpful? Give feedback.
-
Hi @MiloTruck, I have left comments on 220, 207, 205 and 225 I would appreciate it if you would take another look at the issues. |
Beta Was this translation helpful? Give feedback.
-
Hello @MiloTruck, Thanks for judging. I left comments on #27 and #25. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Hi @MiloTruck left a comment on #64. |
Beta Was this translation helpful? Give feedback.
-
@MiloTruck, kindly look at issue #181. |
Beta Was this translation helpful? Give feedback.
-
Hey @MiloTruck, can you please check code-423n4/2024-07-karak-validation#219 |
Beta Was this translation helpful? Give feedback.
-
Hello @MiloTruck, thanks for your time, I think you can take a look at these three issues in karak-validation : |
Beta Was this translation helpful? Give feedback.
-
Hello @MiloTruck! thanks for judging, Left comments on validation 58 and 59. Thanks! |
Beta Was this translation helpful? Give feedback.
-
Hi @MiloTruck, thanks for judging! I've left #22 (comment). Please take a look when you get a chance. |
Beta Was this translation helpful? Give feedback.
-
Hi @MiloTruck thanks for judging. Please take a look at issue 319 in the validation repo, it was invalidated by validators which I believe is a valid issue. The issue describes that if DSS initiates a slashing request and the contracts are paused afterward before the Veto verifies the slash request, the slash can happen immediately without veto's review after the contracts are unpaused. |
Beta Was this translation helpful? Give feedback.
-
Hello @MiloTruck, I think this issue 287 was erroneously invalidated, it should be considered a dupe of 93. Thank you! |
Beta Was this translation helpful? Give feedback.
-
Hello @MiloTruck, Thank you for your judging. |
Beta Was this translation helpful? Give feedback.
-
Hello @MiloTruck, Please have a look at #238 in the validation repo. Thanks in advance! |
Beta Was this translation helpful? Give feedback.
-
Hi @MiloTruck. Thank you for judging this contest. |
Beta Was this translation helpful? Give feedback.
-
Hey @MiloTruck. |
Beta Was this translation helpful? Give feedback.
-
Hey @MiloTruck, Thank you. |
Beta Was this translation helpful? Give feedback.
-
Hi MiloTruck, thanks for judging the contest, left some comments on: 133, 134, 139 & 140. |
Beta Was this translation helpful? Give feedback.
-
From this repo:
From the validation repo:
To ask:
|
Beta Was this translation helpful? Give feedback.
-
Sorry for the late comment but I don't quite understand why #311 in the validation repo is not reviewed. I believe it's a duplicate of #29 in the findings repo. Would greatly appreciate if it could be checked out. |
Beta Was this translation helpful? Give feedback.
-
Hi, @MiloTruck, Could you please check the Issue#105 code-423n4/2024-07-karak-validation#105 Thank you very much |
Beta Was this translation helpful? Give feedback.
-
The judge for this contest is @MiloTruck.
Both the Validation repo and the Findings repo will be open to wardens with the SR role, for the purposes of post-judging QA.
Reminders
Thank you!
Beta Was this translation helpful? Give feedback.
All reactions