New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descriptive-statistics MAX is broken. #10

Open

awb99 opened this issue Sep 24, 2024 · 1 comment

awb99 commented Sep 24, 2024

(dfn/descriptive-statistics [:min :max :mean :n-values] (map #(+ 2.0 %) (range 1000)))
;; => {:min 2, :max 2, :mean 501.5, :n-values 1000}

(dfn/descriptive-statistics [:min :max :mean :n-values] (range 10))
;; => {:min 0, :max 0, :mean 4.5, :n-values 10}

Author

awb99 commented Sep 24, 2024 •

edited

Loading

its an easy fix I think, in statistics:
both min and max use the same mmin-key function.

(defn min
  [v]
  (->> (hamf/apply-nan-strategy nil v)
       (hamf/mmin-key identity)))

(defn max
  [v]
  (->> (hamf/apply-nan-strategy nil v)
       (hamf/mmin-key identity)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment