-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LdapSkipCertificateMockMvcTests test failures in local runs, introduced by PR 2711 #2738
Comments
No issue in my IDE, and no running |
I did some experimenting on my Mac.
This does seem to depend on which tests are run and the order they're run in. |
Using the head of the develop branch - when I run all of the uaa unit tests on my machine like this:
./gradlew test
, both tests in theLdapSkipCertificateMockMvcTests
class (in theserver
module) consistently fail in the setup:I have not seen these test fail on Concourse, only locally. Similar result, though, when I run the tests the way we run them in CI:
I reproduced the two failures in one run like this, but not on another, where one of the UaaTokenServicesTests flaked instead.
Running the
LdapSkipCertificateMockMvcTests
test class alone does not reproduce the failures. The smallest set of tests I've run that reproduced it was to run all of the unit tests in theuaa
module, then concurrently runLdapSkipCertificateMockMvcTests
. It seems that there is some test pollution or a race condition.These failures were introduced in PR #2711 (which doesn't seem to be the root cause), specifically in
JdbcScimUserProvisioning.getUserConfig()
. If I revert the change just in that method (where the new behavior is to throw an exception), these tests pass andJdbcScimUserProvisioningTests.cannotCreateUserWithInvalidIdentityZone
fails.In one attempt at running
run-unit-tests.sh
, however, all the tests passed.The text was updated successfully, but these errors were encountered: