From 69ab7faa6419fd8bc076baf80ee086edc7ca0973 Mon Sep 17 00:00:00 2001 From: anmolnagpal Date: Thu, 7 Mar 2024 19:48:28 +0530 Subject: [PATCH 1/3] feat: added templates --- .github/PULL_REQUEST_TEMPLATE.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ec15a22..de726b2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -19,5 +19,3 @@ describe your code changes in detail for reviewers. Explain the technical soluti - [ ] If it is a core feature, I have added thorough tests. - [ ] Do we need to implement analytics? - [ ] Will this be part of a product update? If yes, please write one phrase about this update. - - From 1fb780355f4edb4527371c061ac9aa77c5d2292a Mon Sep 17 00:00:00 2001 From: anmolnagpal Date: Thu, 7 Mar 2024 21:08:51 +0530 Subject: [PATCH 2/3] feat: added templates --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index de726b2..5a67dfd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,17 +1,13 @@ ## Describe your changes - -added pull request template +added pull request template ## Bug description - Clearly and concisely describe the problem. ## Issue ticket number and link - there was no issue -## Solution description - +## Solution description describe your code changes in detail for reviewers. Explain the technical solution you have provided and how it fixes the issue case. ## Checklist before requesting a review From db6cba9f4754c2fef8795417b9ffe95e62f772fc Mon Sep 17 00:00:00 2001 From: anmolnagpal Date: Wed, 13 Mar 2024 21:19:42 +0530 Subject: [PATCH 3/3] feat: added templates --- .github/PULL_REQUEST_TEMPLATE.md | 51 ++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5a67dfd..81d3e9b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,9 +1,52 @@ + + + ## Describe your changes added pull request template +## **What type of PR is this? (check all applicable)** +- [ ] Refactor +- [ ] Feature +- [ ] Bug Fix +- [ ] Optimization +- [ ] Documentation Update + ## Bug description Clearly and concisely describe the problem. +## Related Tickets & Documents + + + +- Related Issue # +- Closes # + ## Issue ticket number and link there was no issue @@ -15,3 +58,11 @@ describe your code changes in detail for reviewers. Explain the technical soluti - [ ] If it is a core feature, I have added thorough tests. - [ ] Do we need to implement analytics? - [ ] Will this be part of a product update? If yes, please write one phrase about this update. + + +## **Added/updated tests?** +We encourage you to keep the code coverage percentage at 80% and above. + +- [ ] Yes +- [ ] No, and this is why: please replace this line with details on why tests have not been included +- [ ] I need help with writing tests