Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Nexus into the mvp demo #101

Closed
Keith-CY opened this issue Jan 9, 2023 · 15 comments
Closed

Integrate Nexus into the mvp demo #101

Keith-CY opened this issue Jan 9, 2023 · 15 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jan 9, 2023

The MVP DApp is expected to be work with MetaMask at this early stage.

Meanwhile, a browser extension wallet of Nervos CKB, named Nexus(https://github.com/ckb-js/nexus) is under development.

Once Nexus is ready for tests, we will try to support it in the MVP DApp.

@Keith-CY Keith-CY added the documentation Improvements or additions to documentation label Jan 9, 2023
@Keith-CY Keith-CY self-assigned this Jan 9, 2023
@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 1, 2023

We're considering integrating Nexus into the Kuai MVP DApp(#54), any documents would you recommend for us to start? @homura

Online demo: https://kuai-mvp-dapp-ui.vercel.app/

@homura
Copy link
Contributor

homura commented Feb 1, 2023

Nexus don't currently have a friendly document, only a pre-design in the PR, we plan to provide a demo dApp of Nervos DAO to show how to use Nexus. Nexus MVP will probably be released around mid-March

@Keith-CY
Copy link
Member Author

Keith-CY commented Feb 1, 2023

Nexus don't currently have a friendly document, only a pre-design in the PR, we plan to provide a demo dApp of Nervos DAO to show how to use Nexus. Nexus MVP will probably be released around mid-March

Cool, looking forward to it

@Keith-CY
Copy link
Member Author

Keith-CY commented Mar 1, 2023

Tmp ddl: 03/08

@Keith-CY
Copy link
Member Author

Keith-CY commented Mar 6, 2023

@Keith-CY
Copy link
Member Author

Keith-CY commented Mar 14, 2023

There're 3 obstacles on integrating nexus

  1. failed to send a transaction within the demo
Screen.Recording.2023-03-14.at.23.57.07.mov
  1. APIs used in the demo are out of date, but new APIs are documented(https://github.com/ckb-js/nexus/blob/main/docs/rpc.md), so it won't block the development, just not worth doing it now.

  2. The extension doesn't work for unknown reasons

Screen.Recording.2023-03-15.at.00.45.45.mov
3.1. The popup doesn't show on click
3.2. `nexus wallet not found` is prompted in console, which means `nexus` is not injected successfully. However, the `ckb` object is available on interaction, may be caused by the timing of detecting injection. Besides, an instance of `nexus` is expected to be returned by `await ckb.enable()`, but `null` is got instead.
3.3. During integration with kuai MVP, the popup is blank on calling `nexus.enable()`

I will send this feedback to the nexus team tomorrow

@Keith-CY
Copy link
Member Author

Keith-CY commented Mar 14, 2023

After some tries, I found the nexus not found happens after refresh, but will be fixed by hard refresh

Screen.Recording.2023-03-15.at.01.10.46.mov

So the timing of detecting injection is improper. Even though, the balance doesn't show occasionally.

@homura
Copy link
Contributor

homura commented Mar 15, 2023

hi, @Keith-CY could you please provide the following information to help debug

  1. where did you download the Nexus?
  2. if possible, can you provide the Nexus console output

image

@Keith-CY
Copy link
Member Author

hi, @Keith-CY could you please provide the following information to help debug

  1. where did you download the Nexus?
  2. if possible, can you provide the Nexus console output
image

The extension was downloaded from https://github.com/zhangyouxin/demo-nexus/releases/tag/0.1.0, which is prompted in the demo
image


The inspect popup makes the popup always on

Screen.Recording.2023-03-15.at.11.56.19.mov

@zhangyouxin
Copy link

According to the error message prompted when firing a transaction: Incorrect password, I doubt the nexus-wallet-chrome-extension is a deprecated version, so I built another package using the latest code and uploaded it here: https://github.com/zhangyouxin/demo-nexus/releases/tag/0.1.1, could you try this one pls?

@homura
Copy link
Contributor

homura commented Mar 23, 2023

hi, the Nexus MVP is released, and we can download from the release page

@Keith-CY
Copy link
Member Author

hi, the Nexus MVP is released, and we can download from the release page

Great, I'll try it these days

@Keith-CY
Copy link
Member Author

Keith-CY commented Apr 7, 2023

Found another issue blocking the interaction
ckb-js/nexus#188

@Keith-CY
Copy link
Member Author

Keith-CY commented Apr 8, 2023

Front-end: Magickbase/kuai-mvp-dapp-ui#13
Backend: #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

No branches or pull requests

3 participants