Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ready-to-merge label was not set when checks & reviews were green #9

Open
joestringer opened this issue May 7, 2020 · 1 comment
Open

ready-to-merge label was not set when checks & reviews were green #9

joestringer opened this issue May 7, 2020 · 1 comment

Comments

@joestringer
Copy link
Member

PR cilium/cilium#11375,

All CODEOWNERS reviews were satisfied and all checks were green except for GKE which is not required.

However the ready-to-merge label was not set. @christarazi added it manually.
@pchaigno
Copy link
Member

pchaigno commented Oct 1, 2020

Saw another occurrence of this bug at cilium/cilium#13323 (comment). All CIs were green, all codeowners were green, and there were 5 accept reviews + 1 comment review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joestringer @pchaigno