-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIP still uses package source when running under gitified #11
Comments
I don't think this should be fixed from the koha-gitify end, doing so would be a very far reaching and hard to maintain change, koha-gitify aims to be minimally invasive (avoiding breaking non-gitified instances is very important). The ideal fix would be for this to be fixed on the koha side. I had plans to either modify koha-script or introduce a new koha-env script to do such things. The problem with this approach is it would also affect non-gitified koha instances, and for little gain to them. |
For now I am marking this as wontfix as I don't think it is feasible from the koha-gitify end of things. |
What I did on the gitified dev install is simply change the environment path in the koha-start-sip script. Yes, it affects all of the instances, but since it was a test box it didn't much matter. |
@wizzyrea yeah that is an easy fix but for the general case (of wanting to mix gitified and non-gitified) we would most likely need an upstream change for the various cron jobs to obey some path setting (so we could set it per instance) this general case would also work if we wanted many gitified instances but each with a different path. |
Yeah, I was just noting it down for anyone else who needed/wanted a workaround :) |
@wizzyrea +1 |
I never got back to this one.. sorry. I'm using gitified less and less to be honest. I think we're a fringe case, but we come up against allot of these issues pretty often. It's still a great tool, and it's great to see people using it so much.. but for my dev and qa tasks I'll be sticking to full dev type installs for a while yet. |
Currently, it's rather challenging to test code that changes the SIP services under a gitified environment.
When the koha-sip script is envoked, it works with code in /usr/lib/koha instead of the gitified code.
The text was updated successfully, but these errors were encountered: