Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API deployment chart to conditionally load liveness/readiness probes #11

Open
jcadam14 opened this issue May 17, 2024 · 0 comments · May be fixed by #12
Open

Update API deployment chart to conditionally load liveness/readiness probes #11

jcadam14 opened this issue May 17, 2024 · 0 comments · May be fixed by #12
Assignees

Comments

@jcadam14
Copy link
Collaborator

Some services that we reuse these charts with might not have a way to health probe the container, or like the locust service it's a run and done concept.

Add {{- if (default true .Values.healthChecks) }} around the probes to make them optional, defaulting to true so we don't have to update the other override values for this.

@jcadam14 jcadam14 self-assigned this May 17, 2024
@jcadam14 jcadam14 linked a pull request May 20, 2024 that will close this issue
@jcadam14 jcadam14 linked a pull request May 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant