You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 24, 2024. It is now read-only.
The documentation states that lowerLimit and upperLimit of each axis type (x, y, y2) can be a "number or Date". Unfortunately, GraphConfig.validateInput uses the util.isEmpty helper which returns true for a Date object. Yet, if I set either the lowerLimit or upperLimit properties on an existingGraph instance then call reflowMultipleDatasets, it works just fine and doesn't complain.
I'm not sure how you want to determine what is at fault here. Perhaps util.isEmpty is not faulty and it should simply not be used when validating the axis limits. I'll let you all decide.
The text was updated successfully, but these errors were encountered:
terra-graphs/packages/carbon-graphs/src/js/helpers/utils.js
Line 75 in 6c54528
The documentation states that
lowerLimit
andupperLimit
of eachaxis
type (x, y, y2) can be a "number or Date". Unfortunately, GraphConfig.validateInput uses theutil.isEmpty
helper which returnstrue
for a Date object. Yet, if I set either thelowerLimit
orupperLimit
properties on an existingGraph
instance then callreflowMultipleDatasets
, it works just fine and doesn't complain.I'm not sure how you want to determine what is at fault here. Perhaps
util.isEmpty
is not faulty and it should simply not be used when validating the axis limits. I'll let you all decide.The text was updated successfully, but these errors were encountered: