-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create persistent HTTP connection for REST connections #140
Comments
@ronnie-llamado Is this failure related? |
I don't think so. That failure looks like it originates server side since it's an HTTP error 504. It might be worth rerunning the build (especially since ubuntu python 3.9 build passed). |
Yeah, it passes in the PR, but has failed in two reruns on merge. Probably will clear up on its own. |
After triggering a re-run once more, it looks like it just passed. One of those things that comes with testing off a live API. |
Currently a new connection is opened on every HTTP interaction (see log output below). Introducing a
requests.session
tied toAPIConnection
andTigerConnection
objects may show some performance gains, especially on larger transactions.The main difference would amount to changing from
requests.get
toself.session.get
(insideAPIConnection
andTigerConnection
).If done, this will require some refactoring of
remote.py
andtiger.py
. Perhaps even a BaseClass that can be shared between the two.The text was updated successfully, but these errors were encountered: