Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split tunnel incorrectly identified? #1703

Open
samthesamman opened this issue Sep 18, 2024 · 2 comments
Open

split tunnel incorrectly identified? #1703

samthesamman opened this issue Sep 18, 2024 · 2 comments

Comments

@samthesamman
Copy link

Looks like you are just looking for the presence of 0.0.0.0 in allowedIps to determine if it's a full tunnel. But if I set something like allowedIps=0.0.0.0/5, then this should be detected as split tunnel. Not sure if this is just a UI thing or if you have logic that depends on this detection.

@ignoramous
Copy link
Collaborator

ignoramous commented Sep 18, 2024

allowedIps=0.0.0.0/5

We rely on net/netip:IPPrefix.Contains: https://go.dev/play/p/RIcrz4KtOGD

@samthesamman
Copy link
Author

But if allowedIps is set to 0.0.0.0/5, shouldn't this be considered a split tunnel? Your code example considers this full.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants