Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing default values for lat/lon #810

Open
maneesha opened this issue Oct 17, 2023 · 0 comments
Open

Consider removing default values for lat/lon #810

maneesha opened this issue Oct 17, 2023 · 0 comments

Comments

@maneesha
Copy link
Contributor

This template uses default values of (45, -1) for latitude and longitude. See https://github.com/carpentries/workshop-template/blob/gh-pages/index.md?plain=1#L10

This means that if people do not update these values, the page builds successfully, without any "FIXME" style placeholders. This means people may not realize these values need to be updated. Consider replacing the default values with something that either produces an error or makes it clear these are not valid values. Note that (0,0) are valid lat/lon coordinates so that would not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant