Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: Login.gov logo vertical spacing and fix #2427

Open
machikoyasuda opened this issue Oct 7, 2024 · 0 comments
Open

Investigate: Login.gov logo vertical spacing and fix #2427

machikoyasuda opened this issue Oct 7, 2024 · 0 comments
Assignees
Labels
front-end HTML/CSS/JavaScript and Django templates

Comments

@machikoyasuda
Copy link
Member

machikoyasuda commented Oct 7, 2024

What is the visual bug and the ideal design

Ideal: The Login.gov logo on the radio button options on the Eligibility pages that opens the modal should not change paragraph line-height.

Current: The Login.gov logo makes the line-height a little taller.

Screenshots:

https://test-benefits.calitp.org/eligibility/

Image
Image
Image

Scenarios to test

  • Test with and without focus rings
  • Test in Spanish and English
  • Test on all screen widths

Issue details

  • The goal of this issue is to investigate the reason and see if it's possible to get the sentence line-height to be equal, without affecting the alignment of the logo and the question mark icon.

  • Preliminary debugging: Toggling the display: none / block of the entire parent div is helpful to see the line-height difference: Image

  • Possible solution: Turning off this rule: margin: 11px auto 0 auto on .login .fallback-text leads to this: Image And turning off line-height: 1 on .login also seems to help reduce the extra line-height.

@machikoyasuda machikoyasuda added the front-end HTML/CSS/JavaScript and Django templates label Oct 7, 2024
@machikoyasuda machikoyasuda self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates
Projects
Status: In progress
Development

No branches or pull requests

1 participant