Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SET KEYBOARD= case insensitive and eliminate parameter check in MOS. #59

Open
lennart-benschop opened this issue May 17, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@lennart-benschop
Copy link

The MOS SET command does a case sensitive compare of its parameter KEYBOARD. While the MOS commeand names themselves and file names are case-insensitive, the KEYBOARD parameter is case-sensitive.

It also does a compare of the value. More keyboard layouts could be added to the VDP code (plus underlying vpd-gl) and the VDU handler already checks the parameter. It's not a good idea that you have to change the check in MOS, each time you extend the range of supported keyboards in VDP.

@lennart-benschop lennart-benschop changed the title make SET KEYBOARD= case insensitive and make it ignore the parameter. make SET KEYBOARD= case insensitive and eliminate parameter check in MOS. May 17, 2023
@leighbb
Copy link
Contributor

leighbb commented May 24, 2023

As part of #60, I have added strcasecmp(). This would enable this enhancement to be easily done.

@breakintoprogram breakintoprogram added the enhancement New feature or request label May 25, 2023
@breakintoprogram
Copy link
Owner

@lennart-benschop I will keep the check in MOS as it is useful to report back to the user when an invalid set is selected, and is no big deal to update. Will fix the case sensitivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants