Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run release sometimes fails but can be fixed with npm run all #1249

Open
Skaiir opened this issue Aug 26, 2024 · 1 comment
Open

npm run release sometimes fails but can be fixed with npm run all #1249

Skaiir opened this issue Aug 26, 2024 · 1 comment
Labels
backlog Queued in backlog bug Something isn't working technical debt

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Aug 26, 2024

What should we do

Make the release command consistent

Why should we do it

To make our lives easier, we don't release that often but when we do usually getting interrupted because of some obscure fact that we need to run npm run all twice (once as part of the release command) is something that we should improve.

@Skaiir Skaiir added bug Something isn't working backlog Queued in backlog technical debt labels Aug 26, 2024
@Keshav-1803
Copy link

Solution Proposal:

  • Update the Release Script: Modify the package.json file to include a more robust release command that handles all required tasks in one go. For example:

    "scripts": {
        "all": "npm run lint && npm run build && npm run test",
        "release": "npm run all && npm publish"
    }

    In this case, you’ll only need to run npm run release, which internally runs npm run all and handles the full release process, including publishing.

  • Check Existing Processes: Ensure all necessary steps (e.g., linting, testing, building) are included within npm run all or the release command. This avoids missing anything critical during the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working technical debt
Projects
None yet
Development

No branches or pull requests

2 participants