Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jalali calendar support for form date-time element #1207

Open
okaeiz opened this issue Jun 10, 2024 · 3 comments
Open

Jalali calendar support for form date-time element #1207

okaeiz opened this issue Jun 10, 2024 · 3 comments
Assignees
Labels
backlog Queued in backlog enhancement New feature or request

Comments

@okaeiz
Copy link

okaeiz commented Jun 10, 2024

Is your feature request related to a problem? Please describe.

Yes. The Gregorian calendar - which is currently being used in the datetime component - is not useful in some regions. I request implementing a new component, the Jalali datetime.

Describe the solution you'd like

I recommend using this eye-catching Jalai datetime component which is written in Javascript and can be implemented as a new input component.

Describe alternatives you've considered

Another way to implement this functionality would be to add extra configuration to the existing datetime component. Maybe adding a dropdown to the General section of the properties panel and letting the users choose between Gregorian and Jalali dates.

Additional context

This is the datepicker I intend to implement. I am not sure about the rendering procedure yet though.

theme

@okaeiz okaeiz added the enhancement New feature or request label Jun 10, 2024
@okaeiz
Copy link
Author

okaeiz commented Jun 30, 2024

I took a look at flatpickr which is the datepicker library that is used in datetime component, and I found out there's a Jalali support PR already that is made by someone else and it seems to require a review. But the library seems inactive for months.

Is that what we are looking for here? Shall we contribute to that project? As an alternative, I was wondering maybe we could create a locale environment variable for modeler. So when it is set to fa (Persian), the default flatpickr datetime component would be inaccessible and a Jalali component would be enables and ready to use within the form. That's because most users may find it confusing if we let them choose between Gregorian and Jalali calendars. So that should be activated according to the locale. Does that sound like a good idea?

@Skaiir @volodymyr-melnykc

@volodymyr-melnykc
Copy link

@Skaiir How would you recommend handling it? ☝️

@okaeiz
Copy link
Author

okaeiz commented Jul 13, 2024

Any updates? @volodymyr-melnykc @Skaiir

@nikku nikku added the backlog Queued in backlog label Jul 23, 2024 — with bpmn-io-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants