Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render an informative div inside dynamic list items with no children #1163

Open
Skaiir opened this issue Apr 23, 2024 · 1 comment
Open

Render an informative div inside dynamic list items with no children #1163

Skaiir opened this issue Apr 23, 2024 · 1 comment
Labels
backlog Queued in backlog bug Something isn't working

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Apr 23, 2024

Describe the Bug

Currently it is possible to have a dynamic list with no visual elements (expression). This means we can add a bunch of empty rows to a dynamic list. While this affects the state normally, we would rather simply not allow this.

Further investigations: The issue is more complex as it is also needs to consider cases where hide if causes an empty list element. I think we should accept empty items as part of the debugging process, not caring about whether it stems from expressions, hide if, or any other non-visual element. But instead, we should have a more parseable visually empty state instead of what we see below:

image

This is a bit of a pain to handle right now, we should wait on the render refactors for this.

Steps to Reproduce

  1. Add a dynamic list
  2. Add an expression component inside
  3. Items are empty but not very understandable

Expected Behavior

  1. Items should have some information of the type "no visual elements available in item"
@Skaiir Skaiir added bug Something isn't working ready Ready to be worked on labels Apr 23, 2024
@Skaiir Skaiir self-assigned this Apr 23, 2024
@Skaiir
Copy link
Contributor Author

Skaiir commented Sep 10, 2024

Following some more considerations, this should not be tackled until we decouple rendering from form state management. I believe we should have a type of "no visual elements" node rendered instead of strictly treating the whole dynamic list as empty (since this is all dynamic relative to hide-if conditions).

So overall, on hold until refactors.

@Skaiir Skaiir changed the title Treat a dynamic list with no visual elements as empty Render an informative div inside dynamic list items with no children Sep 10, 2024
@Skaiir Skaiir added backlog Queued in backlog and removed ready Ready to be worked on labels Sep 10, 2024
@Skaiir Skaiir removed their assignment Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant