-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to remove available subscription levels & update level labels #198
Comments
Hi, I added this PR to help identify the options available on the Group Email Options tab. Please let me know if you that will work. |
Thank you for the PR - I have merged it. I guess your strategy here is to hide these items with CSS. That seems OK to me, and I definitely have no problem adding the selectors to the markup. That said, a more general solution would be to allow the subscription levels to be filterable. The subscription logic throughout the plugin is really difficult to abstract, and I think it would be very difficult to put a filter in place that allows plugins to add subscription levels. On the other hand, I can imagine a filter that allows you to remove subscription levels. This way, you'd be removing them globally, rather than using a CSS hack. If you think this is useful or promising in some way, perhaps you could work up a PR for it, or maybe I could look at it myself in the future. |
@boonebgorges Agreed that adding a filter to remove subscription levels is best compared to this CSS hack. Our goal is accomplished with #199. Thanks for the merge. |
New Topics Email
andAll Emails
using hooks? I unfortunately was not able to find an easy way to do that globally as these levels seem to be hardcoded in many places.New Topics Email
toNew Topics
)?I see you guys are working on a
v4
, not sure if either of these are planned in that release. Looking forward to hearing from you.The text was updated successfully, but these errors were encountered: