From 862a2ff3f7c406b5a53d146cfe900560e16f198e Mon Sep 17 00:00:00 2001 From: MarcHagen Date: Sat, 30 Jan 2021 21:59:38 +0100 Subject: [PATCH 1/2] Fix recorders are not always a number. Could be a number, representing a channel that's capable of recoding. Or a string starting with m for dedicated recorders --- index.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/index.js b/index.js index b5b31a3..d8b1716 100644 --- a/index.js +++ b/index.js @@ -506,15 +506,12 @@ class EpiphanPearl extends instanceSkel { * * @private * @since 1.0.0 - * @param {String|Number} id + * @param {String} id */ _getRecorderById(id) { if (!id) { return; } - if (typeof id !== 'number') { - id = parseInt(id) - } return this.RECORDER_STATES.find(obj => obj.id === id); } @@ -720,7 +717,7 @@ class EpiphanPearl extends instanceSkel { /** * Part of poller - * INTERNAL: The data poller will activally make requests to update feedbacks and dropdown options. + * INTERNAL: The data poller will actively make requests to update feedbacks and dropdown options. * Polling data such as channels, recorders, layouts and status * * @private @@ -799,7 +796,7 @@ class EpiphanPearl extends instanceSkel { for (const a in recoders) { const recoder = recoders[a]; const updatedRecorder = { - id: parseInt(recoder.id), + id: recoder.id, label: recoder.name }; tempRecorders.push(updatedRecorder); From cb9ea05e2088752ce73d30992e0ed27a41b8d5fd Mon Sep 17 00:00:00 2001 From: MarcHagen Date: Sat, 30 Jan 2021 22:04:11 +0100 Subject: [PATCH 2/2] Bump version 1.0.4 --- CHANGELOG.md | 6 ++++++ package.json | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 19d86d0..c7d3774 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 --- +--- +## [1.0.4] (2021-01-30) + +## Bug Fixes +* [#5](https://github.com/bitfocus/companion-module-epiphan-pearl/issues/5) - Fixed issue with recording not working. + --- ## [1.0.3] (2020-06-16) diff --git a/package.json b/package.json index 85bf4a9..e99c7ca 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "epiphan-pearl", - "version": "1.0.3", + "version": "1.0.4", "manufacturer": "Epiphan", "product": "Pearl", "shortname": "pearl",