Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support OncoKB api agent and auto agent selector #70

Merged
merged 19 commits into from
Aug 19, 2024

Conversation

fengsh27
Copy link
Collaborator

@fengsh27 fengsh27 commented Aug 2, 2024

No description provided.

@slobentanzer
Copy link
Contributor

@fengsh27 thanks! I updated biochatter-server to 0.4.0 and deployed the docker compose. Have two questions:

  1. OncoKB (manual selection) and Auto mode do not seem to trigger; I get a regular response from the model without any RAG.
  2. This being a PR to the main biochatter-next repo, we should not constrain to the specific use case (cancer genetics for instance). It is fine for testing, but the additions to the main repo should always conserve the generic nature of the app. The customisations are to be implemented elsewhere. (Ideally, we would run the cancer genetics use case in the cancer-genetics BioCypher repository, with all configuration there.)

@slobentanzer
Copy link
Contributor

@fengsh27 it would also be great if the app gave some simple feedback on what it is doing, such as Auto mode: selecting tool, Auto mode: selected knowledge graph, Generating query, Reflecting on query, etc.

@fengsh27
Copy link
Collaborator Author

fengsh27 commented Aug 3, 2024

@fengsh27 thanks! I updated biochatter-server to 0.4.0 and deployed the docker compose. Have two questions:

  1. OncoKB (manual selection) and Auto mode do not seem to trigger; I get a regular response from the model without any RAG.
  2. This being a PR to the main biochatter-next repo, we should not constrain to the specific use case (cancer genetics for instance). It is fine for testing, but the additions to the main repo should always conserve the generic nature of the app. The customisations are to be implemented elsewhere. (Ideally, we would run the cancer genetics use case in the cancer-genetics BioCypher repository, with all configuration there.)

@slobentanzer
Regarding 1. it's because biochatter-server changes are not submitted yet, I will raise PR for biochatter-server's change later
Regarding 2. do you mean it is not appropriate to submit biochatter-next.yaml changes here?

@fengsh27
Copy link
Collaborator Author

fengsh27 commented Aug 3, 2024

@fengsh27 it would also be great if the app gave some simple feedback on what it is doing, such as Auto mode: selecting tool, Auto mode: selected knowledge graph, Generating query, Reflecting on query, etc.

Good suggestion. I think we can resolve it in next PR.
Can we show these information in Rag Contextual Prompts dialog

@slobentanzer
Copy link
Contributor

do you mean it is not appropriate to submit biochatter-next.yaml changes here?

We can update the YAML, but only for demonstration purposes (e.g., we can show a second knowledge graph in the config to show users that it's possible); the changes should not change default behaviour of the demo. So, for instance, they should not remove all personas except the configured one. The demo app built from this repo should remain generic.

@slobentanzer
Copy link
Contributor

@fengsh27 since this PR depends on changes to biochatter-server, do you want to wait for these?

@fengsh27
Copy link
Collaborator Author

fengsh27 commented Aug 5, 2024

@fengsh27 since this PR depends on changes to biochatter-server, do you want to wait for these?

No problem, I'm OK with that

@fengsh27
Copy link
Collaborator Author

@slobentanzer I added support of example usage in Welcome page. Please have a look and modify Example content which I will apply to our BioChatter-Next server

@fengsh27
Copy link
Collaborator Author

Are we ready to merge this PR?

@slobentanzer
Copy link
Contributor

Does it work on your end, including my recent changes? If so, then yes.

@fengsh27
Copy link
Collaborator Author

Yes, it works well on my end

@fengsh27 fengsh27 merged commit 6ff977c into main Aug 19, 2024
@fengsh27 fengsh27 deleted the wip/fengsh/API_agent_and_agent_selector branch August 19, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants