Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in global variable #48

Open
slobentanzer opened this issue Jan 30, 2024 · 5 comments
Open

Typo in global variable #48

slobentanzer opened this issue Jan 30, 2024 · 5 comments
Assignees
@fengsh27

Comments

@slobentanzer
Copy link
Contributor

biochatter-next/chatgse/app/constant.ts

Line 179 in 2940b80

export const ERROR_BIOSERVER_UNKNOW = 5000

@fengsh27 is it a problem that this constant ends in UNKNOW instead of UNKNOWN? Could lead to unwanted errors.
@slobentanzer
Copy link
Contributor Author

Also, is it a coincidence that the constant is the same number as the port, 5000?

@slobentanzer
Copy link
Contributor Author

The number is just a coincidence.

@fengsh27, same as the other one, would probably be good to fix the typo in the next submission.

@fengsh27
Copy link
Collaborator

fengsh27 commented Mar 5, 2024

@slobentanzer Sure, will do

@slobentanzer
Copy link
Contributor Author

@fengsh27 reminder that we could get rid of these minor TODOs in the next update

@slobentanzer
Copy link
Contributor Author

@fengsh27 is this fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengsh27 fengsh27

Labels
None yet
Projects
BioCypher Development
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slobentanzer @fengsh27