Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: shell fallback for try-summary and and try-commit break on filenames with newlines #84

Open
angelhof opened this issue Jun 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@angelhof
Copy link
Member

angelhof commented Jun 28, 2023

By @mgree:

The logic could break with particularly nasty filenames (e.g., newlines). The most robust approach is to null terminate, à la find ... -print0 or xargs -0.

(See the discussion in #83)

@mgree mgree added the bug Something isn't working label Jun 29, 2023
@mgree
Copy link
Contributor

mgree commented Jun 11, 2024

I was going to take a whack at fixing this in the shell fallbacks in #158, but it's a bigger overhaul than I initially expected: we can't store the results of find -print0 in a variable. 🥲

@mgree mgree changed the title Summary and Commit break with "bad" filenames bug: shell fallback for try-summary and and try-commit break on filenames with newlines Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants