Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Desktop Sidebar: Example Sets #1637

Open
alexrcabral opened this issue Jan 15, 2021 · 3 comments
Open

Desktop Sidebar: Example Sets #1637

alexrcabral opened this issue Jan 15, 2021 · 3 comments

Comments

@alexrcabral
Copy link

Mockup of v2 Mathshare sidebar on desktop. This shows a profile portrait with the initial A. Underneath is the name Alex C in bold, followed by Teacher, and Signout. The main portion of the sidebar is shown beneath. These options read My Solution Sets, My Created Sets, Example Sets, About Mathshare, Help Center, and Accessibility. My Created Sets is currently active, which is represented by bold, darker font.

In the list of linked options on the sidebar, for logged in users, "Example Sets" should link to the appropriate heading. 

  • If on the main dashboard showing all sets, this should scroll the page (no refresh needed) so the "Example Sets" heading is at the top of the page. 
  • If on another page besides the main dashboard, this should bring the user to the main dashboard, and scroll to the "Example Sets" heading.
  • If the user is in the middle of editing something (e.g. editing a problem, editing a problem set), this should save any edits which have been made prior to bringing the user to the main dashboard and the "Example Sets" heading. 

Acceptance criteria: 

Given that I'm a user on a screen wide enough to view the sidebar, I should encounter the "Example Sets" link underneath either My Sets, or My Solution Sets & My Created Sets. When I click the "Example Sets" link, any edits I've made should be saved (if applicable), and I should be brought to the appropriate heading on the dashboard. 

@abaranowska1
Copy link

@rupeshparab
I noticed that when I open some problem set and then I click Example Sets the page is no scrolled to the right position.
Peek 2021-02-03 14-42

rupeshparab added a commit that referenced this issue Feb 3, 2021
#1637 - scroll only after all data has been loaded
@rupeshparab
Copy link
Collaborator

This issue was coming due to the api taking more time and the scroll hapenning before the data was loaded which was pushing the content down.
I have added a wait for the data to be completely loaded before the scroll happens

@abaranowska1
Copy link

Tested with success
Thanks, now it works fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants