Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce nullable reference types #184

Open
tomrijnbeek opened this issue Jun 1, 2020 · 0 comments · May be fixed by #300
Open

Enforce nullable reference types #184

tomrijnbeek opened this issue Jun 1, 2020 · 0 comments · May be fixed by #300
Assignees
@paulcscharf
Labels
enhancement good-first-issue Great issue to start out with if you're new to the code base and would like to help.

Comments

@tomrijnbeek
Copy link
Member

🆙 Improvement proposal

Null checking has been enabled. This means all nullability warnings need to be fixed. Many cases are pretty straightforward (null is expected, or tests verify null inputs throw exceptions), but in some cases the nullability is undesirable.

All these warnings need to be cleaned up one way or another, before enabling full nullability enforcement.

Context

Null bad. Maybe better.
@tomrijnbeek tomrijnbeek added enhancement good-first-issue Great issue to start out with if you're new to the code base and would like to help. labels Jun 1, 2020
@tomrijnbeek tomrijnbeek mentioned this issue Jun 1, 2020
Merged
@paulcscharf paulcscharf self-assigned this Oct 11, 2020
This was referenced Oct 12, 2020
Merged
Merged
@paulcscharf paulcscharf mentioned this issue Oct 19, 2020
Merged
@Mattias1 Mattias1 mentioned this issue Oct 20, 2020
Merged
artog added a commit to artog/beardgame-utilities that referenced this issue Oct 24, 2022
@artog
Moved MutableLinkedList, and its enumerator and node, to nullable (be…
22f604e 
…ardgame#184)
artog added a commit to artog/beardgame-utilities that referenced this issue Oct 24, 2022
@artog
Moved actions to be explicitly nullable (beardgame#184)
82f91fb
artog added a commit to artog/beardgame-utilities that referenced this issue Oct 24, 2022
@artog
Moved DeletableObjectList + Enumerator to nullable (beardgame#184)
67150aa
artog added a commit to artog/beardgame-utilities that referenced this issue Oct 24, 2022
@artog
Complete remake of Maybe using abstract class. Aimed for easier maint…
07d7912 
…enance and understanding. (beardgame#184)
artog added a commit to artog/beardgame-utilities that referenced this issue Oct 24, 2022
@artog
Mixed nullable fixes (beardgame#184)
8baa6be
@artog artog linked a pull request Oct 24, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulcscharf paulcscharf

Labels
enhancement good-first-issue Great issue to start out with if you're new to the code base and would like to help.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transition to using explicit nullable types (#184) artog/beardgame-utilities
2 participants
@tomrijnbeek @paulcscharf