Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Source.get_prices_series when fetching many prices #45

Open
doriath opened this issue Apr 10, 2021 · 1 comment
Open

Use Source.get_prices_series when fetching many prices #45

doriath opened this issue Apr 10, 2021 · 1 comment

Comments

@doriath
Copy link
Contributor

doriath commented Apr 10, 2021

Instead of sending one HTTP request per requested date, we could use existing Source.get_prices_series method to fetch price for multiple days using one HTTP.

I tried fetching the prices of one ticker for the last 8 years (based on my ledger), and after few minutes the tool failed. I locally hacked the tool to use Source.get_prices_series and I got all prices in ~2s. I will try to clean up my code and get it in good enough shape to send a PR.
@Ledarium
Copy link

@doriath any news on this? I would like to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doriath @Ledarium