Fix MethodError when hashing Pair #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `internal_type_structure` for `Pair` since `keytype` and `valuetype` are not defined for `Pair`. * Add unit test for hashing `Pair`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 93.55% 93.57% +0.01%
==========================================
Files 7 7
Lines 667 669 +2
==========================================
+ Hits 624 626 +2
Misses 43 43 ☔ View full report in Codecov by Sentry. |
haberdashPI
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR,
stable_hash(2=>3, HashVersion{4}())fails with aMethodError.See #71
This PR fixes this by implementing
internal_type_structureforPair, which was needed sincekeytypeandvaluetypeare not defined forPair.It also adds unit tests.
This PR should not affect any benchmarks.