-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gather_metadata_info
does not populate the package_info
field of the returned TransitiveMetadataInfo
#154
Comments
Sounds like a bug to me. A perfect thing to look into after vacation
…On Wed, Sep 11, 2024, 1:25 PM Simon Stewart ***@***.***> wrote:
Expected Behavior
When using the gather_metadata_info aspect, the generated
TransitiveMetadataInfo should have all fields populated.
Actual Behavior
Only deps, licenses, and traces are populated.
Steps to Reproduce the Problem
1. Use the gather_metadata_info aspect on a target
2. Inspect the returned TransitiveMetadataInfo provider
It looks like the call to the factory method doesn't include a reference
to the gathered PackageInfo instances:
https://github.com/bazelbuild/rules_license/blob/main/rules/licenses_core.bzl#L204-L210
—
Reply to this email directly, view it on GitHub
<#154>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC22ZWMPPBDFTTHBIB4YHPTZWASBTAVCNFSM6AAAAABOAXW3P6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTSNBWGM4DIMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
When using the
gather_metadata_info
aspect, the generatedTransitiveMetadataInfo
should have all fields populated.Actual Behavior
Only
deps
,licenses
, andtraces
are populated.Steps to Reproduce the Problem
gather_metadata_info
aspect on a targetTransitiveMetadataInfo
providerIt looks like the call to the factory method doesn't include a reference to the gathered
PackageInfo
instances: https://github.com/bazelbuild/rules_license/blob/main/rules/licenses_core.bzl#L204-L210The text was updated successfully, but these errors were encountered: