Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs say this is still a proof of concept #153

Open
davidben opened this issue Sep 10, 2024 · 5 comments
Open

Docs say this is still a proof of concept #153

davidben opened this issue Sep 10, 2024 · 5 comments

Comments

@davidben
Copy link

The documentation for rules_license says:

Proof of concept. License restriction.

https://bazelbuild.github.io/rules_license/latest.html

That seems to suggest this is not yet ready for general use, but Bazel's documentation already suggests using it.
https://bazel.build/reference/be/functions#package.default_package_metadata

Is the documentation out-of-date, or is this package not yet ready?

@jcecil
Copy link

jcecil commented Sep 20, 2024

CC @aiuto

@alexeagle
Copy link

See #152

@tonyaiuto
Copy link
Collaborator

The docs are out of date, and there is a lot of work to be done. We're doing a BOF at BazelCon in October, where we will do some direction setting.

@davidben
Copy link
Author

Can the phrase "proof of concept" be removed before then? We were asked to adopt this project but the documentation made it extremely difficult to have confidence that we could safely do so.

@jcecil
Copy link

jcecil commented Oct 21, 2024

I wasn't able to attend BazelCon unfortunately (I look forward to watching the vods later), but I didn't see any discussion topics related to licenses. Was this discussed?

I just want to confirm that rules_license is the way forward. My project has deps that use the old and new way of defining licenses, and my strategy for handling it depends on this decision. Should I work on updating my dependencies to use the new version, or should I try to make my project support deps that use either version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants