Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SAP client compilation failure with Update 10 #6905

Closed
1 of 2 tasks
TharmiganK opened this issue Aug 23, 2024 · 1 comment · Fixed by ballerina-platform/module-ballerinax-sap#21
Closed
1 of 2 tasks

Fix SAP client compilation failure with Update 10 #6905

TharmiganK opened this issue Aug 23, 2024 · 1 comment · Fixed by ballerina-platform/module-ballerinax-sap#21
Assignees
@TharmiganK
Labels
module/sap Priority/High Type/Task

Comments

@TharmiganK
Copy link
Contributor

TharmiganK commented Aug 23, 2024 •
edited
Loading

Description:

The HTTP package has introduced a change in the client invocation return type(http:Response|anydata -> http:Response|anydata|stream<http:SseEvent, error?>. This change is breaking the SAP client.

Describe your task(s)

  • Fix the breaking change
  • Release a new version for Update 10
@TharmiganK TharmiganK self-assigned this Aug 23, 2024
@TharmiganK TharmiganK mentioned this issue Aug 23, 2024
Merged
5 tasks
@TharmiganK
Copy link
Contributor Author

TharmiganK commented Aug 23, 2024 •
edited
Loading

Tested the following connector repos with the fix:

  • module-ballerinax-sap.s4hana.qm
  • module-ballerinax-sap.s4hana.sales
  • module-ballerinax-sap.s4hana.procurement
  • module-ballerinax-sap.s4hana.inventory
  • module-ballerinax-sap.s4hana.delivery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TharmiganK TharmiganK

Labels
module/sap Priority/High Type/Task
Projects
Ballerina Team Main Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use custom TargetType as the client return type ballerina-platform/module-ballerinax-sap
1 participant
@TharmiganK